Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brave based web search function #30

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Add Brave based web search function #30

merged 1 commit into from
Apr 15, 2024

Conversation

codingjoe
Copy link
Member

No description provided.

@codingjoe codingjoe merged commit 660fdf0 into main Apr 15, 2024
4 checks passed
@codingjoe codingjoe deleted the webs-earch branch April 15, 2024 12:13
@@ -12,6 +12,7 @@ requires-python = ">=3.11"
dependencies = [
"click",
"redis",
"requests",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like using https://github.com/encode/httpx for my new projects - as it is faster and supports async.

)

def search(self, query):
response = self.get(f"{self.endpoint}/web/search", params={"q": query})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No timeout?

"query": {
"bad_results": False,
"city": "",
"country": "us",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why us here?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants