Spit the package into voici-core and voici

[martinRenou]

This PR splits the repo into two packages:

• voici-core: provides the CLI and the jupyterlite addon
• voici: a meta-package that ships both voici-core and jupyterlite-xeus-python (will switch to using jupyterlite-xeus in a separate PR)

[github-actions]

👈 Try it on ReadTheDocs

[martinRenou]

check-release is driving me nuts, using some system yarn for some reason

[jtpio]

check-release is driving me nuts, using some system yarn for some reason

Were you able to find the reason a system-wide yarn would be picked up?

[trungleduc]

check-release is driving me nuts, using some system yarn for some reason

Were you able to find the reason a system-wide yarn would be picked up?

Because jupyterlab/maintainer-tools/.github/actions/base-setup@v1 installs yarn 1 by default.

[jtpio]

Should the docs mention the two voici-core and voici packages?

For reference the JupyterLite docs try to stick to mentioning jupyterlite-core because this is what provides the CLI: https://jupyterlite.readthedocs.io/en/stable/

Also the jupyterlite metapackage removed the dependency on jupyterlite-pyodide-kernel in jupyterlite/jupyterlite#1147.

If the voici metapackage depends on jupyterlite-xeus, it would be nice to explain why.

[jtpio]

Also it may be useful to provide a migration guide, so folks who are already currently using the voici package in their deployments with a different kernel (for example jupyterlite-pyodide-kernel) know why they would start pulling jupyterlite-xeus-python when they update to a newer version.

[martinRenou]

Thank you for the review!

I'd like to work on improving the documentation when the move to jupyterlite-xeus is done. Let's do that in a separate PR. Does it sound good @jtpio ?

[trungleduc]

the package/voici package should live outside of python/voici-core?

[martinRenou]

the package/voici package should live outside of python/voici-core?

Should it? It seems to me this package only builds an index.js that is shipped by voici-core.

Otherwise we'd need two package.json in the repo, one for packages/voici and one for voici-core which depends on the first. I'm not sure I see the benefit of this?

[trungleduc]

the package/voici package should live outside of python/voici-core?

Should it? It seems to me this package only builds an index.js that is shipped by voici-core.

Otherwise we'd need two package.json in the repo, one for packages/voici and one for voici-core which depends on the first. I'm not sure I see the benefit of this?

maybe not. It's just the general layout of a mono-python/js repo

[jtpio]

I'd like to work on improving the documentation when the move to jupyterlite-xeus is done. Let's do that in a separate PR. Does it sound good @jtpio ?

Sure. Maybe this would also require addressing jupyterlite/xeus#17 first.

Just trying to think of ways for making this internal change as smooth as possible for existing Voici users.

[trungleduc]

Just trying to think of ways for making this internal change as smooth as possible for existing Voici users.

We can release this change in a major version? Maybe starting 0.6.0 alphas with this PR

[martinRenou]

So do you guys think there are blockers for this PR? What do you think about merging and we iterate upon it?

[trungleduc]

I think it's good to go

[trungleduc]

Thanks @martinRenou !