-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to JupyterLab v3.1 and support RTC #142
Conversation
…he notebook is already executed or not.
This PR is ready. We need to wait for two PRs in JupyterLab: Then we can remove: voila-gridstack/packages/jupyterlab-gridstack/src/editor/gridstack/model.ts Lines 83 to 84 in f9d99f3
and Lines 38 to 39 in f9d99f3
Some of the changes I made:
|
Thanks for this!
Looks like these PRs have now been merged and released. Maybe we can do one more bump to 3.1.9 before merging this one? |
We could also add the |
Hey, great to see you are back!
Yes, we need to update to 3.1.9 because the I'll do it today. |
.eslintrc.js
Outdated
// TODO: Remove ban-ts-comment | ||
'@typescript-eslint/ban-ts-comment': 'off', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be removed now that it has been updated to 3.1.9?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following-up on the comment: #142 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just tested locally and it works great!
This is a draft PR to update to JupyterLab v3.1 and add support for RTC.
Due to some attributes on the notebook's metadata (
kernelspecs
andlanguage_info
), we don't share the notebook's metadata by default.TODO:
Demo:
demo_voila-gridstack_rtc.mp4