Update to jupyter-packaging v0.10

[hbcarlos]

@jtpio Can we simplify the development build?

voila-gridstack/setup.py

Lines 69 to 97 in 99c1b35

	class DevelopCmd(base_develop_cmd):
	prefix_targets = [
	("nbconvert/templates", 'gridstack'),
	("voila/templates", 'gridstack')
	]
	def run(self):
	target_dir = os.path.join(sys.prefix, 'share', 'jupyter')
	if '--user' in sys.prefix: # TODO: is there a better way to find out?
	target_dir = jupyter_core_paths.user_dir()
	target_dir = os.path.join(target_dir)
	for prefix_target, name in self.prefix_targets:
	source = os.path.join('share', 'jupyter', prefix_target, name)
	target = os.path.join(target_dir, prefix_target, name)
	target_subdir = os.path.dirname(target)
	if not os.path.exists(target_subdir):
	os.makedirs(target_subdir)
	rel_source = os.path.relpath(os.path.abspath(source), os.path.abspath(target_subdir))
	try:
	os.remove(target)
	except:
	pass
	print(rel_source, '->', target)
	os.symlink(rel_source, target)
	super(DevelopCmd, self).run()
	cmdclass['develop'] = DevelopCmd if jupyter_core_paths else base_develop_cmd

[jtpio]

Yes I think so.

There used to be a similar one in voila before, which is now gone: https://github.com/voila-dashboards/voila/blob/master/setup.py

[jtpio]

We can even combine this line with the one above with *.md.

[hbcarlos]

Yes, but I wanted to add both separately to know exactly what we need.
Is the RELEASE.md necessary?

[jtpio]

Ah right. Then I guess it's fine to leave it like it is now.

[hbcarlos]

It's done, but I would like to create a symlink to the nbconvert folder for gridstack, when running pip install -e .. That's what this code was doing:

voila-gridstack/setup.py

Lines 69 to 97 in 99c1b35

	class DevelopCmd(base_develop_cmd):
	prefix_targets = [
	("nbconvert/templates", 'gridstack'),
	("voila/templates", 'gridstack')
	]
	def run(self):
	target_dir = os.path.join(sys.prefix, 'share', 'jupyter')
	if '--user' in sys.prefix: # TODO: is there a better way to find out?
	target_dir = jupyter_core_paths.user_dir()
	target_dir = os.path.join(target_dir)
	for prefix_target, name in self.prefix_targets:
	source = os.path.join('share', 'jupyter', prefix_target, name)
	target = os.path.join(target_dir, prefix_target, name)
	target_subdir = os.path.dirname(target)
	if not os.path.exists(target_subdir):
	os.makedirs(target_subdir)
	rel_source = os.path.relpath(os.path.abspath(source), os.path.abspath(target_subdir))
	try:
	os.remove(target)
	except:
	pass
	print(rel_source, '->', target)
	os.symlink(rel_source, target)
	super(DevelopCmd, self).run()
	cmdclass['develop'] = DevelopCmd if jupyter_core_paths else base_develop_cmd

Could we create and script or something and run it with npm_builder() in the post-build process?

[jtpio]

Maybe we still want to keep the metadata for the Python package separate from the JupyterLab extension?

So we don't use this description for the template:

voila-gridstack/packages/jupyterlab-gridstack/package.json

Line 4 in 99c1b35

"description": "A JupyterLab extension to create Voila dashboards using GridStack",

[hbcarlos]

That's right, I'll change. I'll use the setup.cfg to add the metadata for the python package then.

[jtpio]

And we can even move most of this to setup.cfg, similar to: https://github.com/voila-dashboards/voila/blob/main/setup.cfg

[hbcarlos]

I'm setting the version in the setup.cfg manually because that runs the python package during the build process, and it fails because the labextension is not built yet.

[jtpio]

I'm setting the version in the setup.cfg manually because that runs the python package during the build process, and it fails because the labextension is not built yet.

Sounds good 👍 We'll want to version the Python package and the lab extension separately anyway.

Later when we do the releaser PR, we can move the Python version to _version.py (and expose it as __version__), and use something like bump2version or tbump to update it (that will be for the version-cmd for the releaser)

[jtpio]

This could also be:

Suggested change

	requires = ["jupyter_packaging~=0.10,<2", "jupyterlab~=3.1", "jupyterlab_widgets~=1.0", "voila>=0.2.0,<0.3.0"]
	requires = ["jupyter_packaging~=0.10,<2", "jupyterlab~=3.1", "jupyterlab_widgets~=1.0", "voila~=0.2.0"]

[jtpio]

Thanks!

[jtpio]

This should be good to merge, and we can iterate afterwards as part of #147

[hbcarlos]

Thank you so much Jeremy!