Resize widgets when resizing cells or document #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbcarlos
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resize widgets when resizing cells or document
This PR improves the UI/UX experience but has a downside in performance.
Every time the user resizes a cell, we propagate the resize event to the widget inside the cell. This rerenders the widget. Another possibility would be to propagate the event when the resize stops or debouce the propagation to not rerender the widget so many times.
Regarding the document, this PR listens for a resize event on the widget and, when the resize stops, propagates the event to every widget rendered in the layout.
Also added a new GitHub action to comment the binder link for each PR.
plotly-example.mp4