Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating jupyterlab-widget version #186

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Conversation

anick16
Copy link
Contributor

@anick16 anick16 commented Oct 20, 2022

Updating jupyterlab-widget version to 3.0
#185

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch anick16/voila-gridstack/main

@martinRenou
Copy link
Member

@hbcarlos Why is jupyterlab_widgets a dependency? This should probably be removed entirely.

@anick16 if your intent was to make voila-gridstack support ipywidgets 8, I'm sorry to say this will not work... You will need to wait for Voila 0.4.0 to be out (it's coming very soon).

@hbcarlos
Copy link
Member

@hbcarlos Why is jupyterlab_widgets a dependency? This should probably be removed entirely.

To be able to load the widget in two document views at the same time. Once we make widgets collaborative, we could remove the dependency.

@anick16
Copy link
Contributor Author

anick16 commented Oct 24, 2022

@anick16 if your intent was to make voila-gridstack support ipywidgets 8, I'm sorry to say this will not work... You will need to wait for Voila 0.4.0 to be out (it's coming very soon).

@martinRenou Not looking to upgrade ipywidgets to 8. I am facing conflicts with other packages as voila-gridstack has hard
dependency on jupyterlab-wigdets==1.0 which is pretty old version. The latest is jupyterlab-wigdets==3.0.
Details are here- #185

@hbcarlos
Copy link
Member

hbcarlos commented Nov 4, 2022

Thanks, @anick16! Looks good. Sorry for the delay.

@hbcarlos hbcarlos merged commit 363b3f2 into voila-dashboards:main Nov 4, 2022
@hbcarlos hbcarlos added enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 4, 2022
@hbcarlos hbcarlos self-requested a review December 16, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants