Skip to content

Commit

Permalink
Merge pull request #1198 from kianmeng/fix-typos
Browse files Browse the repository at this point in the history
Fix typos
  • Loading branch information
jtpio committed Sep 8, 2022
2 parents c9c6db5 + d813096 commit b588c06
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -917,7 +917,7 @@
- help: show more configurable classes with --help-all, and use consistent naming [#331](https://github.com/voila-dashboards/voila/pull/331) ([@maartenbreddels](https://github.com/maartenbreddels))
- Fix example use for config attribute resources [#323](https://github.com/voila-dashboards/voila/pull/323) ([@mkcor](https://github.com/mkcor))
- Fix Windows develop install [#322](https://github.com/voila-dashboards/voila/pull/322) ([@vidartf](https://github.com/vidartf))
- test: set timeout of pytest_tornado to 20 seconds to avoid false CI failured [#321](https://github.com/voila-dashboards/voila/pull/321) ([@maartenbreddels](https://github.com/maartenbreddels))
- test: set timeout of pytest_tornado to 20 seconds to avoid false CI failures [#321](https://github.com/voila-dashboards/voila/pull/321) ([@maartenbreddels](https://github.com/maartenbreddels))
- fix: ignore non-jupyter-widget comm_open messages at the backend, causing 500 errors for users. [#319](https://github.com/voila-dashboards/voila/pull/319) ([@maartenbreddels](https://github.com/maartenbreddels))
- feat: make the markdown rendered configurable in VoilaExporter [#317](https://github.com/voila-dashboards/voila/pull/317) ([@maartenbreddels](https://github.com/maartenbreddels))
- Clear output before executing the notebook [#314](https://github.com/voila-dashboards/voila/pull/314) ([@jeffyjefflabs](https://github.com/jeffyjefflabs))
Expand Down
2 changes: 1 addition & 1 deletion voila/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ def hook(req: tornado.web.RequestHandler,
Although most customizations can leverage templates, if you need access
to the request object (e.g. to inspect cookies for authentication),
or to modify the notebook itself (e.g. to inject some custom structure,
althought much of this can be done by interacting with the kernel
although much of this can be done by interacting with the kernel
in javascript) the prelaunch hook lets you do that.
"""
),
Expand Down
2 changes: 1 addition & 1 deletion voila/handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ async def get_generator(self, path=None):
current_notebook_data: Dict = self.kernel_manager.notebook_data.get(notebook_path, {})
pool_size: int = self.kernel_manager.get_pool_size(notebook_path)
except AttributeError:
# For server extenstion case.
# For server extension case.
current_notebook_data = {}
pool_size = 0

Expand Down
10 changes: 5 additions & 5 deletions voila/request_info_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@

class RequestInfoSocketHandler(WebSocketHandler):
"""A websocket handler used to provide the request info
assocciated with kernel ids in preheat kernel mode.
associated with kernel ids in preheat kernel mode.
Class variables
---------------
- _waiters : A dictionary which holds the `websocket` connection
assocciated with the kernel id.
associated with the kernel id.
- cache : A dictionary which holds the request info assocciated
- cache : A dictionary which holds the request info associated
with the kernel id.
"""
_waiters = dict()
Expand All @@ -38,12 +38,12 @@ def on_close(self) -> None:

@classmethod
def send_updates(cls: 'RequestInfoSocketHandler', msg: Dict) -> None:
"""Class method used to dispath the request info to the waiting
"""Class method used to dispatch the request info to the waiting
notebook. This method is called in `VoilaHandler` when the request
info becomes available.
If this method is called before the opening of websocket connection,
`msg` is stored in `_cache0` and the message will be dispatched when
a notebook with coresponding kernel id is connected.
a notebook with corresponding kernel id is connected.
Args:
- msg (Dict): this dictionary contains the `kernel_id` to identify
Expand Down

0 comments on commit b588c06

Please sign in to comment.