Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support specifying a custom markdown renderer in Voila #234

Closed
SylvainCorlay opened this issue Jun 13, 2019 · 2 comments · Fixed by #317
Closed

Support specifying a custom markdown renderer in Voila #234

SylvainCorlay opened this issue Jun 13, 2019 · 2 comments · Fixed by #317
Assignees
@maartenbreddels
Labels
Feature Request

Comments

@SylvainCorlay
Copy link
Member

We need to make the markdown renderer a configurable option for the VoilaExporter so that third party can provide their own implementation and create custom handling of e.g. links in markdown cells.
@SylvainCorlay
Copy link
Member Author

cc @cquah

@maartenbreddels
Copy link
Member

I think we should add this to VoilaConfiguration.

@maartenbreddels maartenbreddels self-assigned this Jul 22, 2019
maartenbreddels added a commit to maartenbreddels/voila that referenced this issue Jul 22, 2019
@maartenbreddels
feat: make the markdown rendered configurable in VoilaExporter
0979974 
Example configuration (e.g. in voila.json) could be:

'VoilaExporter': {
    'markdown_renderer_class': 'my.package.MyMarkdownRenderer'
}

Closes voila-dashboards#234
@maartenbreddels maartenbreddels mentioned this issue Jul 22, 2019
Merged
maartenbreddels added a commit to maartenbreddels/voila that referenced this issue Jul 22, 2019
@maartenbreddels
feat: make the markdown rendered configurable in VoilaExporter
8246c87 
Example configuration (e.g. in voila.json) could be:

'VoilaExporter': {
    'markdown_renderer_class': 'my.package.MyMarkdownRenderer'
}

Closes voila-dashboards#234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maartenbreddels maartenbreddels

Labels
Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make the markdown rendered configurable in VoilaExporter maartenbreddels/voila
2 participants
@maartenbreddels @SylvainCorlay