feat: make the markdown rendered configurable in VoilaExporter #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example configuration (e.g. in voila.json) could be:
'VoilaExporter': {
'markdown_renderer_class': 'my.package.MyMarkdownRenderer'
}
Closes voila-dashboards#234
maartenbreddels
force-pushed
the
feat_config_markdown_renderer
branch
from
0979974
to
8246c87
Compare
|
Thanks @maartenbreddels ! @aschlaep for awareness |
|
This looks good to me. Thanks for tackling this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example configuration (e.g. in voila.json) could be:
Closes #234
We could argue that we want this to be in nbconvert, but we can have it in voila first, upstream it later without having compatibility issues.