Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prelaunch hooks with fixed test dep #1148

Closed
wants to merge 9 commits into from
Closed

Prelaunch hooks with fixed test dep #1148

wants to merge 9 commits into from

Conversation

alkasm
Copy link
Contributor

@alkasm alkasm commented Apr 26, 2022

Attempt to fix CI errors from #724

  • reenable prelaunch-hook
  • add docs
  • fix lint and indent issue
  • pass handler down into hook
  • add test, fix bug in passing tornado handler
  • add papermill example and test
  • move papermill to test deps

References

Code changes

User-facing changes

Backwards-incompatible changes

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch alkasm/voila/alkasm/prelaunch_hook

@alkasm alkasm mentioned this pull request Apr 26, 2022
Merged
@alkasm alkasm closed this Apr 26, 2022
@alkasm alkasm deleted the alkasm/prelaunch_hook branch April 26, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alkasm @timkpaine