UTF7 repack corrected #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function _repack_utf7_callback is converting incorrectly non utf7 strings. example: Chassis+FanTray10G-VSS is removed from original html (text) when added a test to detect if base64_encode(base64_decode($str))===$str PHP was thrown an error: return must be string, returned array
voku
added a commit
that referenced
this pull request
Apr 26, 2018
voku
added a commit
that referenced
this pull request
Apr 26, 2018
-> #34 # Conflicts: # src/voku/helper/AntiXSS.php
voku
added a commit
that referenced
this pull request
Apr 26, 2018
-> #34 # Conflicts: # src/voku/helper/AntiXSS.php
|
Thank you for the fix. There was a issue with the string comparison, so I added the fix in a new commit + a test case for your example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
function _repack_utf7_callback is converting incorrectly non utf7 strings.
example: Chassis+FanTray10G-VSS is removed from original html (text)
when added a test to detect if base64_encode(base64_decode($str))===$str
PHP was thrown an error: return must be string, returned array
This change is