-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Not valid HTML fragment!" on default WordPress theme HTML #81
Comments
-> I added a new parameter, where we can keep some html hacks to prevent php errors because of missing html5 / svg support.
Thanks for the bug report, the problem is that php do not support html5 or svg by default, so I added one more hack.
|
Almost! Getting the same error in a different place:
Commenting out the check here "fixes" it, but of course it needs some tooling: https://github.com/voku/simple_html_dom/blob/3636fe85b0bdc96fc397a4718942455b86d8f986/src/voku/helper/SimpleHtmlDom.php#L198L204 |
And just to clarify, does |
Never mind! I just set up a pull request: Simply-Static/simply-static#28 |
PS: do you still see the |
I forgot to change all instances of |
What is this feature about (expected vs actual behaviour)?
I was using @patrickposner's simply-static WordPress plugin and came across a bug when generating static files through his plugin using the 'twentytwentytwo' theme. You can see the related issue here: Simply-Static/simply-static#27
@patrickposner believed it was an issue with the theme not producing valid HTML according to W3, but when you remove the
<style id='wp-block-image-inline-css'>...</style>
tag, the static file generation works. Also, the CSS inside of the style tag is valid, according to W3's CSS validator (you'll need to plug it in).How can I reproduce it?
I created this repository with the bare minimum code that reproduces this bug: https://github.com/Inclushe/voku-simple-html-dom-style-bug
test.html comes from https://twentytwentytwodemo.wordpress.com/
It should show this error when run:
Removing the
<style id='wp-block-image-inline-css'>...</style>
tag from test.html and running the script again produces no errors.PHP Version: 7.4.27
Does it take minutes, hours or days to fix?
No clue.
Any additional information?
Nope.
The text was updated successfully, but these errors were encountered: