refactor(language-core): remove fileName
property for VirtualFile
#124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fileName
is a concept specific to TypeScript, it should not be part of the dependencies of virtual code.Changes
VirtualFile
interface has been renamed toVirtualCode
.VirtualFile.typescript
property, now you need to return the virtual code for the TypeScript LanguageService throughLanguagePlugin.typescript.getScript()
.ServiceEnvironment.fileNameToUri
,ServiceEnvironment.uriToFileName
have been moved toServiceEnvironment.typescript.fileNameToUri
,ServiceEnvironment.typescript.uriToFileName
.[source_file_uri]?virtualCodeId=[virtual_code_id]
. For example:file:///GitHub/volar-starter/src/App.vue?virtualCodeId=script
For actual changes, you can refer to: volarjs/starter@403a3d3