Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deployment and pod, high priority cannot preempt low priority resources #2630

Merged
merged 1 commit into from Dec 30, 2022

Conversation

wangyang0616
Copy link
Member

@wangyang0616 wangyang0616 commented Dec 29, 2022

Signed-off-by: wangyang wangyang289@huawei.com

fix: #2629

The test results are as follows:

[root@ecs-4b42-0002 volcano]# kubectl get pod 
NAME                           READY   STATUS    RESTARTS   AGE
deploy-high-587b867944-9qdvm   1/1     Running   0          40m
deploy-high-587b867944-dzfsr   0/1     Pending   0          40m
deploy-high-587b867944-msvxv   0/1     Pending   0          40m
deploy-high-587b867944-qtfbb   0/1     Pending   0          40m
deploy-low-67b97db94b-7wt2h    1/1     Running   0          40m
deploy-low-67b97db94b-scsx5    1/1     Running   0          40m
deploy-low-67b97db94b-vw8fv    1/1     Running   0          40m
deploy-low-67b97db94b-z44fq    0/1     Pending   0          40m

deploy-high can preempt the resources of deploy-low, but only one copy has preempted resources.

Because when the deployment type creates a podgroup, the default setting minAvailble is 1. Under the control of the gang plugin, only one copy will be preempted.

If you want the behavior to be exactly the same as kube-scheduler and trigger the preemption action of all replicas, you can configure the following information in the volcano-test-scheduler-configmap file

- name: gang
   enableJobStarving: false

… priorityclass when minavailable information is not configured

Signed-off-by: wangyang <wangyang289@huawei.com>
@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 29, 2022
@jiangkaihua
Copy link
Contributor

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 30, 2022
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2022
@volcano-sh-bot volcano-sh-bot merged commit 6bbd098 into volcano-sh:master Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For services other than job, such as deployment and pod, high priority cannot preempt low priority resources
4 participants