Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick for 1.7 #2635

Merged
merged 3 commits into from Dec 30, 2022
Merged

Cherry pick for 1.7 #2635

merged 3 commits into from Dec 30, 2022

Conversation

wangyang0616
Copy link
Member

wangyang0616 and others added 3 commits December 30, 2022 20:16
@wangyang0616
Allow native types such as deployment and pod to preempt according to…
0f9d7d3 
… priorityclass when minavailable information is not configured

Signed-off-by: wangyang <wangyang289@huawei.com>
@wangyang0616
In the preemption scenario, the taskMinAvailble configuration is not …
80419a1 
…concerned, only the jobMinAvailble is concerned

Signed-off-by: wangyang <wangyang289@huawei.com>
@jimoosciuc @wangyang0616
Fixed issue on PodGroup's minResource: extended resource(such as nvid…
e5f4c0f 
…ia.com/gpu) is missing

Signed-off-by: jimoosciuc <bruceleee522@gmail.com>
@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 30, 2022
hwdef
hwdef reviewed Dec 30, 2022
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 30, 2022
william-wang
william-wang approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2022
@volcano-sh-bot volcano-sh-bot merged commit 4d8d486 into volcano-sh:release-1.7 Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@william-wang william-wang william-wang approved these changes

@alcorj-mizar alcorj-mizar Awaiting requested review from alcorj-mizar

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@wpeng102 wpeng102 Awaiting requested review from wpeng102

Assignees

@william-wang william-wang

@hwdef hwdef

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wangyang0616 @volcano-sh-bot @william-wang @hwdef @jimoosciuc