Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix predicate return #3553

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix predicate return #3553

wants to merge 4 commits into from

Conversation

lowang-bh
Copy link
Member

@lowang-bh lowang-bh commented Jun 29, 2024 •
edited
Loading

fixes #3086

Part-2 of filter out those nodes which are UnschedulableAndUnresolvable when preempting #3432
Please merge 3432 first.

pod messages examples image

@volcano-sh-bot volcano-sh-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 29, 2024
@lowang-bh lowang-bh force-pushed the fixPredicateReturn branch 2 times, most recently from 9d05134 to c2210f3 Compare June 29, 2024 07:54
@lowang-bh lowang-bh mentioned this pull request Jul 13, 2024
Merged
@volcano-sh-bot volcano-sh-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 15, 2024
@Monokaix
Copy link
Member

When upgrade from 1.8/1.9 to 1.10 seems compatibility issue wil also occur: )

@lowang-bh lowang-bh closed this Jul 19, 2024
@lowang-bh lowang-bh reopened this Jul 19, 2024
@lowang-bh
Copy link
Member Author

lowang-bh commented Jul 19, 2024 •
edited
Loading

When upgrade from 1.8/1.9 to 1.10 seems compatibility issue wil also occur: )

Currently, no body has reported the issue after release 1.8/1.9. So maybe they did't met this issue without self-developed plugins.

@lowang-bh lowang-bh force-pushed the fixPredicateReturn branch 2 times, most recently from 1d9bfd9 to bdfb40c Compare July 20, 2024 04:43
@lowang-bh
fix predicate return value: just need error
9d0582b 
Signed-off-by: lowang-bh <lhui_wang@163.com>
@lowang-bh
refact testcase in usage plugin with uthelper framework
fa3bcb6 
Signed-off-by: lowang-bh <lhui_wang@163.com>

Signed-off-by: lowang-bh <lhui_wang@163.com>
@lowang-bh
refact testcase in nodegroup plugin with uthelper framework
2b02a38 
Signed-off-by: lowang-bh <lhui_wang@163.com>
@lowang-bh lowang-bh closed this Jul 20, 2024
@lowang-bh lowang-bh reopened this Jul 20, 2024
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign lowang-bh
You can assign the PR to them by writing /assign @lowang-bh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@william-wang william-wang william-wang left review comments

@Monokaix Monokaix Monokaix left review comments

@wangyang0616 wangyang0616 wangyang0616 left review comments

@googs1025 googs1025 googs1025 left review comments

@k82cn k82cn Awaiting requested review from k82cn

@shinytang6 shinytang6 Awaiting requested review from shinytang6

@Thor-wl Thor-wl Awaiting requested review from Thor-wl

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Predicate function retrun value is not compatiable with old plugins
6 participants
@lowang-bh @Monokaix @volcano-sh-bot @william-wang @wangyang0616 @googs1025