Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated dind in favor of kind in develop doc #502

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

akillcool
Copy link
Contributor

Corrected doc file name as well as info of dind(which was deprecated, and has switched to kind.

@volcano-sh-bot
Copy link
Contributor

Welcome @akillcool!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2019
@akillcool
Copy link
Contributor Author

/assign @quinton-hoole

@TravisBuddy
Copy link

Hey @akillcool,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 83094a90-fbd9-11e9-9ef7-03a460f81868

@k82cn
Copy link
Member

k82cn commented Oct 31, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akillcool, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2019
@volcano-sh-bot volcano-sh-bot merged commit 20b0327 into volcano-sh:master Oct 31, 2019
@akillcool akillcool deleted the doc_fix branch October 31, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants