Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify the 'vcctl job run' function #542

Merged
merged 1 commit into from
Nov 27, 2019
Merged

modify the 'vcctl job run' function #542

merged 1 commit into from
Nov 27, 2019

Conversation

jiangkaihua
Copy link
Contributor

@jiangkaihua jiangkaihua commented Nov 20, 2019 •
edited
Loading

now vcctl job run can used asvcctl job run -N <job name> -n <namespace> -i <image>
and vcctl job run with no arguments will throw error

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 20, 2019
@TravisBuddy
Copy link

Hey @jiangkaihua,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 03cd6870-0bb9-11ea-9cd6-8f216fa7db85

k82cn
k82cn reviewed Nov 21, 2019
View reviewed changes
pkg/cli/job/run.go Outdated
if job == nil {
fmt.Printf("Error: job script (specified by --filename or -f) is mandatory to run a particular job")
return nil
if job == nil && launchJobFlags.Name != "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if job name is nil, we should return error here.

@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 21, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @jiangkaihua,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e29d3ab0-0c0b-11ea-9cd6-8f216fa7db85

@volcano-sh-bot volcano-sh-bot added retest-not-required-docs-only approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2019
@jiangkaihua jiangkaihua reopened this Nov 21, 2019
@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed retest-not-required-docs-only approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 21, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @jiangkaihua,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 0afdba10-0c0d-11ea-9cd6-8f216fa7db85

@TravisBuddy
Copy link

Travis tests have failed

Hey @jiangkaihua,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: fa05b3c0-0c0c-11ea-9cd6-8f216fa7db85

@TravisBuddy
Copy link

Travis tests have failed

Hey @jiangkaihua,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e83253b0-0c2f-11ea-9cd6-8f216fa7db85

@volcano-sh-bot volcano-sh-bot added retest-not-required-docs-only approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 21, 2019
@jiangkaihua jiangkaihua reopened this Nov 21, 2019
@volcano-sh-bot volcano-sh-bot removed retest-not-required-docs-only approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 21, 2019
@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 21, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @jiangkaihua,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: ba23fc00-0c32-11ea-9cd6-8f216fa7db85

@TravisBuddy
Copy link

Travis tests have failed

Hey @jiangkaihua,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: c91f9610-0c32-11ea-9cd6-8f216fa7db85

@TravisBuddy
Copy link

Travis tests have failed

Hey @jiangkaihua,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 7bf8dc30-0ccc-11ea-9489-798921b627f8

@TravisBuddy
Copy link

Hey @jiangkaihua,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 9a6fda90-0f30-11ea-b3c6-2f81db3b77d2

@TravisBuddy
Copy link

Travis tests have failed

Hey @jiangkaihua,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: bfabcb20-0f62-11ea-b3c6-2f81db3b77d2

modify the unit-test of 'vcctl job run'
aa70e97 
Signed-off-by: jiangkaihua <jiangkaihua1@huawei.com>
@TravisBuddy
Copy link

Hey @jiangkaihua,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 75080a80-0f6b-11ea-b3c6-2f81db3b77d2

@k82cn
Copy link
Member

k82cn commented Nov 27, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiangkaihua, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2019
@volcano-sh-bot volcano-sh-bot merged commit 024f005 into volcano-sh:master Nov 27, 2019
@jiangkaihua jiangkaihua mentioned this pull request Sep 20, 2022
Merged
@jiangkaihua jiangkaihua mentioned this pull request Dec 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn k82cn left review comments

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiangkaihua @TravisBuddy @k82cn @volcano-sh-bot