Skip to content

Commit

Permalink
Added failure node description to InsufficientOperationalNodesException
Browse files Browse the repository at this point in the history
  • Loading branch information
Chinmay Soman committed Aug 17, 2011
1 parent 66ebfe4 commit d0bb21a
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 13 deletions.
5 changes: 3 additions & 2 deletions src/java/voldemort/store/routed/action/PerformParallelDeleteRequests.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
import voldemort.store.nonblockingstore.NonblockingStoreCallback;
import voldemort.store.routed.BasicPipelineData;
import voldemort.store.routed.Pipeline;
import voldemort.store.routed.Response;
import voldemort.store.routed.Pipeline.Event;
import voldemort.store.routed.Response;
import voldemort.store.slop.HintedHandoff;
import voldemort.store.slop.Slop;
import voldemort.utils.ByteArray;
Expand Down Expand Up @@ -222,7 +222,8 @@ public void requestComplete(Object result, long requestTime) {
.getSimpleName()
+ "s required, but only "
+ pipelineData.getSuccesses()
+ " succeeded",
+ " succeeded. Failing nodes : "
+ pipelineData.getFailedNodes(),
pipelineData.getFailures()));
pipeline.abort();
quorumSatisfied = false;
Expand Down
8 changes: 5 additions & 3 deletions src/java/voldemort/store/routed/action/PerformParallelPutRequests.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@
import voldemort.store.nonblockingstore.NonblockingStore;
import voldemort.store.nonblockingstore.NonblockingStoreCallback;
import voldemort.store.routed.Pipeline;
import voldemort.store.routed.Pipeline.Event;
import voldemort.store.routed.PutPipelineData;
import voldemort.store.routed.Response;
import voldemort.store.routed.Pipeline.Event;
import voldemort.store.slop.HintedHandoff;
import voldemort.store.slop.Slop;
import voldemort.utils.ByteArray;
Expand Down Expand Up @@ -243,7 +243,8 @@ public void requestComplete(Object result, long requestTime) {
.getSimpleName()
+ "s required, but only "
+ pipelineData.getSuccesses()
+ " succeeded",
+ " succeeded. Failing nodes : "
+ pipelineData.getFailedNodes(),
pipelineData.getFailures()));
pipeline.abort();
quorumSatisfied = false;
Expand Down Expand Up @@ -292,7 +293,8 @@ public void requestComplete(Object result, long requestTime) {
.getSimpleName()
+ "s required zone, but only "
+ zonesSatisfied
+ " succeeded"));
+ " succeeded. Failing nodes : "
+ pipelineData.getFailedNodes()));
pipeline.abort();
}
}
Expand Down
5 changes: 3 additions & 2 deletions src/java/voldemort/store/routed/action/PerformParallelRequests.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@
import voldemort.store.nonblockingstore.NonblockingStoreCallback;
import voldemort.store.routed.BasicPipelineData;
import voldemort.store.routed.Pipeline;
import voldemort.store.routed.Response;
import voldemort.store.routed.Pipeline.Event;
import voldemort.store.routed.Pipeline.Operation;
import voldemort.store.routed.Response;
import voldemort.utils.ByteArray;
import voldemort.utils.Utils;

Expand Down Expand Up @@ -172,7 +172,8 @@ else if(pipeline.getOperation() == Operation.GET_VERSIONS)
.getSimpleName()
+ "s required, but only "
+ pipelineData.getSuccesses()
+ " succeeded",
+ " succeeded. Failing nodes : "
+ pipelineData.getFailedNodes(),
pipelineData.getFailures()));

pipeline.abort();
Expand Down
5 changes: 3 additions & 2 deletions src/java/voldemort/store/routed/action/PerformSerialGetAllRequests.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
import voldemort.store.Store;
import voldemort.store.routed.GetAllPipelineData;
import voldemort.store.routed.Pipeline;
import voldemort.store.routed.Response;
import voldemort.store.routed.Pipeline.Event;
import voldemort.store.routed.Response;
import voldemort.utils.ByteArray;
import voldemort.utils.Time;
import voldemort.versioning.Versioned;
Expand Down Expand Up @@ -162,7 +162,8 @@ public void execute(Pipeline pipeline) {
.getSimpleName()
+ "s required, but "
+ successCount.intValue()
+ " succeeded",
+ " succeeded. Failing nodes : "
+ pipelineData.getFailedNodes(),
pipelineData.getFailures()));
pipeline.addEvent(Event.ERROR);
return;
Expand Down
5 changes: 3 additions & 2 deletions src/java/voldemort/store/routed/action/PerformSerialPutRequests.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
import voldemort.store.InsufficientZoneResponsesException;
import voldemort.store.Store;
import voldemort.store.routed.Pipeline;
import voldemort.store.routed.PutPipelineData;
import voldemort.store.routed.Pipeline.Event;
import voldemort.store.routed.PutPipelineData;
import voldemort.utils.ByteArray;
import voldemort.utils.Time;
import voldemort.versioning.VectorClock;
Expand Down Expand Up @@ -132,7 +132,8 @@ public void execute(Pipeline pipeline) {
.getSimpleName()
+ "s required, but only "
+ pipelineData.getSuccesses()
+ " succeeded",
+ " succeeded. Failing nodes : "
+ pipelineData.getFailedNodes(),
pipelineData.getFailures()));
pipeline.abort();
} else {
Expand Down
5 changes: 3 additions & 2 deletions src/java/voldemort/store/routed/action/PerformSerialRequests.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
import voldemort.store.StoreRequest;
import voldemort.store.routed.BasicPipelineData;
import voldemort.store.routed.Pipeline;
import voldemort.store.routed.Response;
import voldemort.store.routed.Pipeline.Event;
import voldemort.store.routed.Response;
import voldemort.utils.ByteArray;
import voldemort.utils.Time;

Expand Down Expand Up @@ -107,7 +107,8 @@ public void execute(Pipeline pipeline) {
.getSimpleName()
+ "s required, but only "
+ pipelineData.getSuccesses()
+ " succeeded",
+ " succeeded. Failing nodes : "
+ pipelineData.getFailedNodes(),
pipelineData.getFailures()));

pipeline.abort();
Expand Down

0 comments on commit d0bb21a

Please sign in to comment.