voldemort.store.routed.action.AbstractAction

[dnascimento]

I profiled my application (on Wildfly 8) and I found that Logger.getLogger, in voldemort.store.routed.action.AbstractAction, imposes a significative overhead. I would recommend to set it as static to reduce this overhead

[arunthirupathi]

Can you share your metrics ? Can you also share how long did you run the
tests and what is the get/put/getall/delete load you applied on the server
? Is this a single machine test or multi machine test ?

getLogger is supposed to return the cached instance and not create a new
one every time.

http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/Logger.html#getLogger(java.lang.String)

If you change this to static, then every instance of the log will show
AbstractAction, instead of the respective action which will confuse a lot
in logging.

So I want to weigh the pros and cons, before making any changes.

Thanks,
Arun.

On Sat, Oct 4, 2014 at 8:04 AM, Dário Nascimento notifications@github.com
wrote:

I profiled my application (on Wildfly 8) and I found that
Logger.getLogger, in voldemort.store.routed.action.AbstractAction,
imposes a significative overhead. I would recommend to set it as static
to reduce this overhead

—
Reply to this email directly or view it on GitHub
#222.