Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T023 What is a kinase? #120

Merged
merged 3 commits into from
Sep 23, 2021
Merged

Conversation

dominiquesydow
Copy link
Collaborator

@dominiquesydow dominiquesydow commented Aug 10, 2021

Description

https://app.reviewnb.com/volkamerlab/teachopencadd/pull/120

Todos

Content

  • Theory
    • Kinase dataset
    • Kinase similarity descriptor: XXX
  • Practical
    • Retrieve and preprocess data
    • Show kinase coverage
    • Compare kinases
    • Visualize similarity as kinase matrix
    • Visualize similarity as phylogenetic tree

Content review

  • Potential labels or categories (e.g. machine learning, small molecules, online APIs): XXXXXXXX
  • One line summary: XXXXXXXXXX
  • The table of contents reflects the talktorial story-line; order of #, ##, ### headers is correct
  • URLs are linked with meaningful words, instead of pasting the URL directly or linking words like here.
  • I have spell-checked the notebook
  • Images have enough resolution to be rendered with quality, without being too heavy.
  • All figures have a description
  • Markdown cell content is still in-line with code cell output (whenever results are discussed)
  • I have checked that cell outputs are not incredibly long (this applies also to DataFrames)
  • Formatting looks correctly on the Sphinx render (bold, italics, figure placing)

Code review

  • Time it took to execute (approx.):
  • Variable and function names follow snake case rules (e.g. a_variable_name vs aVariableName)
  • Spacing follows PEP8 (run Black on the code cells if needed)
  • Code line are under 99 characters each (run black -l 99)
  • Comments are useful and well placed
  • There are no unpythonic idioms like for i in range(len(list)) (see slides)
  • All 3rd party dependencies are listed at the top of the notebook
  • I have marked all code cell with output referenced in markdown cells with the label # TODO: CI
  • I have identified potential candidates for a code refactor / useful functions
  • All import ... lines are at the top (practice part) cell, ordered by standard library / 3rd party packages / our own (teachopencadd.*)
  • I have update the relative paths to absolute paths.
  • List here unfamiliar libraries you find in the imports and their intended use:

Questions

  • TBA

Status

  • Ready to go

@dominiquesydow dominiquesydow self-assigned this Aug 10, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dominiquesydow dominiquesydow changed the title T023 - What is a kinase? T023 What is a kinase? Aug 10, 2021
@dominiquesydow dominiquesydow changed the base branch from master to kinase-talkorials August 10, 2021 12:18
@dominiquesydow dominiquesydow added the enhancement New feature or request label Aug 10, 2021
@dominiquesydow dominiquesydow added the new talktorial New talktorial label Sep 8, 2021
@AndreaVolkamer
Copy link
Member

@dominiquesydow and @t-kimber

I added an outline for how we could structure the short intro to kinases in general, then we could use the practical part to compile the input data for the remaining notebooks.
Potentially the practical part could also include some automated queries to create some of the mentioned figures, but this is optional.

@t-kimber t-kimber merged commit 406f554 into kinase-talkorials Sep 23, 2021
@t-kimber
Copy link
Contributor

We will address this PR in the kinase-talkorials branch to avoid too many conflicts (see PR #115).

@dominiquesydow dominiquesydow deleted the ds-t023-what-is-a-kinase branch September 23, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new talktorial New talktorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants