Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base branch for new kinase talkorials #115

Merged
merged 187 commits into from Dec 10, 2021
Merged

Base branch for new kinase talkorials #115

merged 187 commits into from Dec 10, 2021

Conversation

dominiquesydow
Copy link
Collaborator

@dominiquesydow dominiquesydow commented Aug 10, 2021

Description

Add a new batch of 7 6 kinase-focused talktorials (emphasizing on kinase similarity).

Per notebook, create new branch (tk-t024-kinsim-seq) and set up PR (T024 - Title).

Todos

https://app.reviewnb.com/volkamerlab/teachopencadd/pull/115/

Questions

  • ???

Status

  • Ready to go

@dominiquesydow dominiquesydow added the enhancement New feature or request label Aug 10, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@t-kimber
Copy link
Contributor

Dear @dominiquesydow and @AndreaVolkamer ,
I finished checking the HTML rending for this set of notebooks. Going through them a month later made me love them even more <3
The CI seems to be failing, but besides this small (wink wink) issue, this PR is ready to be merged IMO!
What a nice project it has been :)

@dominiquesydow
Copy link
Collaborator Author

Dear @dominiquesydow and @AndreaVolkamer , I finished checking the HTML rending for this set of notebooks. Going through them a month later made me love them even more <3

Thank you, @t-kimber, for making them HTML-ready ❤️ I share your sentiment towards our kinase talktorials :)

The CI seems to be failing, but besides this small (wink wink) issue, this PR is ready to be merged IMO!

That made me laugh a lot, given that I am trying to fix the CI fails for T018 just now :D

What a nice project it has been :)

Absolutely agreed! :)

@t-kimber
Copy link
Contributor

Just mentioning here that the CI is now passing (even though it doesn't look like it ;) ) and that this PR is officially ready for the world. Hallelujah!

@t-kimber
Copy link
Contributor

t-kimber commented Nov 29, 2021

Added library: dataframe_image, see https://github.com/dexplo/dataframe_image
Why? Convert pandas styler dataframe to png.
Conda installation:
conda install -c conda-forge dataframe_image

We will drop this option and load images instead.
If one needs an external package, look at this discussion #184

Libraries for loading images, see https://towardsdatascience.com/what-library-can-load-image-in-python-and-what-are-their-difference-d1628c6623ad

Copy link
Contributor

@t-kimber t-kimber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve? Ohh yes, 100% !! ❤️ 💟 😍

@t-kimber
Copy link
Contributor

The kinase similarity collection is ready, with thumbnails and everything 🎉

@dominiquesydow
Copy link
Collaborator Author

@t-kimber just triggering the CI again, so that we know our notebooks have not picked up any dependency conflicts in the meantime (because external packages were updated or something like this).

@t-kimber t-kimber merged commit a0d2179 into master Dec 10, 2021
@dominiquesydow dominiquesydow deleted the kinase-talkorials branch March 28, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new talktorial New talktorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants