Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T025 Kinase similarity: KiSSim fingerprint #121

Merged
merged 9 commits into from
Aug 24, 2021

Conversation

dominiquesydow
Copy link
Collaborator

@dominiquesydow dominiquesydow commented Aug 10, 2021

Description

https://app.reviewnb.com/volkamerlab/teachopencadd/pull/121

Todos

Content

  • Theory
    • Kinase dataset
    • Kinase similarity descriptor: XXX
  • Practical
    • Retrieve and preprocess data
    • Show kinase coverage
    • Compare kinases
    • Save kinase distance matrix
    • Visualize similarity as kinase matrix > in T028
    • Visualize similarity as phylogenetic tree > in T028

Content review

  • Potential labels or categories (e.g. machine learning, small molecules, online APIs): kinase, similarity, binding site
  • One line summary: Assess kinase similarity based on kinase pocket structure
  • The table of contents reflects the talktorial story-line; order of #, ##, ### headers is correct
  • URLs are linked with meaningful words, instead of pasting the URL directly or linking words like here.
  • I have spell-checked the notebook
  • Images have enough resolution to be rendered with quality, without being too heavy.
  • All figures have a description
  • Markdown cell content is still in-line with code cell output (whenever results are discussed)
  • I have checked that cell outputs are not incredibly long (this applies also to DataFrames)

Code review

  • Time it took to execute (approx.):
  • Variable and function names follow snake case rules (e.g. a_variable_name vs aVariableName)
  • Spacing follows PEP8 (run Black on the code cells if needed)
  • Code line are under 99 characters each (run black -l 99)
  • Comments are useful and well placed
  • There are no unpythonic idioms like for i in range(len(list)) (see slides)
  • All 3rd party dependencies are listed at the top of the notebook
  • I have marked all code cell with output referenced in markdown cells with the label # TODO: CI
  • I have identified potential candidates for a code refactor / useful functions
  • All import ... lines are at the top (practice part) cell, ordered by standard library / 3rd party packages / our own (teachopencadd.*)
  • I have update the relative paths to absolute paths.
  • List here unfamiliar libraries you find in the imports and their intended use: -

Questions

None.

Status

  • Ready to go

@dominiquesydow dominiquesydow added the enhancement New feature or request label Aug 10, 2021
@dominiquesydow dominiquesydow self-assigned this Aug 10, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dominiquesydow dominiquesydow changed the base branch from master to kinase-talkorials August 10, 2021 12:19
@dominiquesydow dominiquesydow merged commit 878ad38 into kinase-talkorials Aug 24, 2021
@dominiquesydow dominiquesydow deleted the ds-t025-kinsim-kissim branch August 24, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant