Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TheCount's "Cleanup and bugfixes", merge-able #5

Merged
merged 24 commits into from
Jan 8, 2015

Conversation

r00t-
Copy link
Collaborator

@r00t- r00t- commented Jan 7, 2015

changes from #1 or #1 with conflicts resolved
(prefers TheCount's version over HEAD due to lack of better knowledge)

@andig
Copy link

andig commented Jan 8, 2015

Ich kanns nicht überblicken. Vorschlag: Test mit meinem Zähler und commit wenn ok. Revert bei Problemen.

@r00t-
Copy link
Collaborator Author

r00t- commented Jan 8, 2015

+1
hab' selber keinen sml-zaehler

@andig
Copy link

andig commented Jan 8, 2015

Compile 2 Warnings.

cc -I./include/ -fPIC -fno-stack-protector -g -std=c99 -Wall -Wextra -pedantic -c -o src/sml_number.o src/sml_number.c

src/sml_number.c: In function ‘sml_number_init’:
src/sml_number.c:30:49: warning: unused parameter ‘type’ [-Wunused-parameter]

cc -I../sml/include/ -g -std=c99 -Wall -Wextra -pedantic -c sml_server.c -o sml_server.o

sml_server.c: In function ‘main’:
sml_server.c:79:14: warning: unused parameter ‘argc’ [-Wunused-parameter]
sml_server.c:79:27: warning: unused parameter ‘argv’ [-Wunused-parameter]

@andig
Copy link

andig commented Jan 8, 2015

wfm.

andig added a commit that referenced this pull request Jan 8, 2015
TheCount's "Cleanup and bugfixes", merge-able
@andig andig merged commit aa7519d into volkszaehler:master Jan 8, 2015
@devZer0
Copy link

devZer0 commented Jan 9, 2015

huh, das war aber nen fettes changeset. werds mal morgen abend mein parsesml gegen die neue version kompilieren/testen...

@r00t- r00t- deleted the thecount-fixes branch November 6, 2018 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants