Refactor entity generation #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andig
force-pushed
the
entityfactory
branch
7 times, most recently
from
628cdce
to
11bd3dd
Compare
andig
force-pushed
the
entityfactory
branch
from
11bd3dd
to
d100fc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bigger rewrite of the various methods for creating entities. The current code had become quite complex with creation of entities split across various places and coupled with the request context. That made it hard to use from custom scripts.
With this PR all entity generation is moved into an
EntityFactory. The use of entity name instead of UUID (in case of a single, public entity of that name) is now possible throughout the API.Additional tests have been added to verify exception error messages for empty uuids/ non-existing uuids/ non-existing public entity names.