Check config in build(..), and throw Error if config is bad

voloko · Feb 7, 2012 · 1383433 · 1383433
1 parent 15da8c9
commit 1383433
Showing 1 changed file with 3 additions and 10 deletions.
diff --git a/main.js b/main.js
@@ -5,22 +5,15 @@ var fs = require('fs'),
     logger = require('./lib/logger'),
     moduleGrapher = require('module-grapher');
 
-function checkConfig(config) {
-  if (config.minify && config.cache) {
-    return 'Cannot minify code when using cache.';
-  }
-  return '';
-}
-
 exports.build = build;
 function build(main, config, callback) {
   if (!callback) {
     callback = config;
     config = {};
   }
-  var configErr = checkConfig(config);
-  if (configErr) {
-    callback(configErr);
+  if (config.minify && config.cache) {
+    var err = new Error('Cannot minify code when using cache.');
+    callback(err);
     return;
   }
   moduleGrapher.graph(main, config, function(err, result) {