Use sort_by to preserve user-defined order of package installs #479
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #478
Use
sort_by
and specify an ordering function to do the sorting of tools. That sorting function explicitly treats Node as the lowest, followed by Npm, Yarn, and Packages, but within each category it ignores the specifics and treats all tools as the same.Per the rust docs,
Vec::sort_by
is stable, so by treating all of the Packages as equal, the original order (provided by the user) will be preserved.Note: We use
sort_by
as opposed to a custom implementation of theOrd
trait because the docs specify that the implementations ofOrd
andPartialEq
must match exactly, and we use the derivedPartialEq
implementation elsewhere so it can't be changed.