Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ZDOTDIR env var in setup command #799

Merged
merged 2 commits into from
Aug 22, 2020
Merged

Support ZDOTDIR env var in setup command #799

merged 2 commits into from
Aug 22, 2020

Conversation

MunifTanjim
Copy link
Contributor

charlespierce
charlespierce requested changes Aug 22, 2020
View reviewed changes
Copy link
Contributor

@charlespierce charlespierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, it looks like a great improvement to play well with the zsh environment! One small suggestion to make the code slightly more idiomatic Rust, but apart from that LGTM!

src/command/setup.rs Outdated Show resolved Hide resolved
@MunifTanjim @charlespierce
Update src/command/setup.rs
aac7df0 
Co-authored-by: Charles Pierce <charlespierce@users.noreply.github.com>
charlespierce
charlespierce approved these changes Aug 22, 2020
View reviewed changes
Copy link
Contributor

@charlespierce charlespierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge after CI finishes. Thanks!

@charlespierce charlespierce merged commit 39c85d9 into volta-cli:main Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlespierce charlespierce charlespierce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MunifTanjim @charlespierce