Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test login service and refactor code #17

Merged
merged 2 commits into from
Jun 16, 2024
Merged

Conversation

voltgizerz
Copy link
Owner

@voltgizerz voltgizerz commented Jun 16, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@voltgizerz voltgizerz added root Application root changes internal Application internal changes mocks File mocks updated labels Jun 16, 2024
Copy link

✅ Test coverage is above the threshold. Good job!

  • Coverage: 19.2%, Threshold: 10%

@voltgizerz voltgizerz added the workflows Workflows updated label Jun 16, 2024
Copy link

✅ Test coverage is above the threshold. Good job!

  • Coverage: 19.2%, Threshold: 10%

@voltgizerz voltgizerz self-assigned this Jun 16, 2024
@voltgizerz voltgizerz merged commit c0f9dd3 into develop Jun 16, 2024
4 checks passed
@voltgizerz voltgizerz deleted the felix_refactor branch June 23, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Application internal changes mocks File mocks updated root Application root changes workflows Workflows updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants