Fix regression with volumecontroller #1961
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I seem to have introduced issues with the software mixer with dd3f21a, sorry!
This is just fixing the symptoms, as I believe the linting has unearthed the real error which was just being silently ignored.
The error comes from these comparisons:
The problem was that
vol
was nevernull
when the parsing failed, but instead wasundefined
.Thus
undefined == null => true
butundefined === null => false
Now this brings to light the actual underlying issue.
Both the regular expressions, fails to parse software mixer output, which doesn't contain
Playback
If you give me a few samples of different mixer outputs, we can write some tests as well..