Add LastFM to the store #59

Saiyato · 2022-01-21T19:22:11Z

Initial upload of LastFM to the Volumio 3 store.

To adhere to the new standard

Fix category (miscellanea doesn't exist anymore)

Fix syntax error

To meet Volumio3 requirements

Tune node dep

1. Fix move to new category 2. Fix crashes when used unauthenticated

volumio · 2022-02-07T21:14:17Z

Excellent.
Why dont you ship it with an Api key for the plugin? This will make it much easier for users to use it

volumio · 2022-02-07T21:49:08Z

One more thing: the icon for the service is not right. Please update it according to the other icons examples

Saiyato · 2022-02-08T07:50:41Z

I don't ship it with my key, because then I also need to provide my own secret and it would be linked to my account. Apart from not feeling comfortable sharing that information, I think a new version should have auth happening using the Volumio auth-service. What is needed to do this?
What is wrong with the service icon? It's "fa-lastfm", and the svg-file is only used for albumart (in the browse-area). I can't find any guidelines as to what kind of icon should be used instead.

PS: I did see a typo in index.js ("fa fa-lastfm" instead of "fa-lastfm"); but it translates to the same.

  "volumio_info": {
    "prettyName": "LastFM Scrobbler",
    "icon": "fa-lastfm",

Saiyato added 8 commits January 21, 2022 20:21

Add LastFM to the store

e88a4a1

Initial upload of LastFM to the Volumio 3 store.

Update package.json

1af96b8

To adhere to the new standard

Update package.json

1b8754e

Fix category (miscellanea doesn't exist anymore)

Update package.json

38f81b6

Fix syntax error

Update package.json

f0fd0c6

To meet Volumio3 requirements

Update package.json

03b9a10

Update package.json

84313dc

Tune node dep

Fix two bugs

a9747fd

1. Fix move to new category 2. Fix crashes when used unauthenticated

volumio merged commit 27fede7 into volumio:master Feb 7, 2022

Provide feedback