Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assorted fixes to Dev environment & github workflow #905

Merged
merged 4 commits into from
Apr 9, 2020
Merged

Assorted fixes to Dev environment & github workflow #905

merged 4 commits into from
Apr 9, 2020

Conversation

zach-sim
Copy link
Contributor

@zach-sim zach-sim commented Apr 8, 2020 •
edited
Loading

  • This modifies checkEnv to only log error and not throw it. This prevent the additional db scripts from failing.
  • Adds the dbName to the mongodb_uri environment variable.
  • Makes the node-version more specific in the github workflow to prevent an issue with 12.16.2 node. (Post-Install Failure on node 12.16.2 nodejs/full-icu-npm#46)
  • Fixes a linting issue

@zach-sim zach-sim requested a review from asomervell April 8, 2020 20:20
@zach-sim zach-sim changed the title Modify checkEnv to log error Assorted fixes to Dev environment & github workflow Apr 8, 2020
@avowkind avowkind merged commit 0f29b2f into master Apr 9, 2020
@avowkind avowkind deleted the modify-check-env branch April 9, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avowkind avowkind avowkind approved these changes

@asomervell asomervell Awaiting requested review from asomervell

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@zach-sim @avowkind