Updating for Node 0.6.0 and newer NPM #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voodootikigod
pushed a commit
that referenced
this pull request
Nov 25, 2011
Updating for Node 0.6.0 and newer NPM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So these commits fix three separate issues:
First, NPM complains about bugs[web] being used instead of bugs[url], so a simple update to the package.json file fixes that.
Second, since this package now uses node's built-in http request, there's no need for the vendored request plugin anymore.
Third, the "sys" module has been renamed to "util" in node 0.6.0+ which causes warnings when running code. Since the sys module wasn't actually used, I just removed the require completely.
Cheers,
Scott