Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global position plugin #118

Merged
merged 3 commits into from
Aug 15, 2014
Merged

Global position plugin #118

merged 3 commits into from
Aug 15, 2014

Conversation

TSC21
Copy link
Member

@TSC21 TSC21 commented Aug 14, 2014

Here's the inital release of the global position plugin. Needs completion and testing!
There are some thing that must be added though (not sure how to do it):

  • See how to receive time_boot_ms and how to convert it to ros::time();
  • Probably we have to consider the NavSatStatus here too, but I'm not sure.

Please @vooon feel free to give an opinion and some tips on this.

The gps_conversions.h file also allow us to convert from local UTM to GPS coordinates, which can also be good on the APM case (considering that this one accepts more than just NMEA convention).

Fix #87.

@vooon
Copy link
Member

vooon commented Aug 15, 2014

I added Fix #87 to PR description. Maybe best to place gps header to include dir?

@vooon
Copy link
Member

vooon commented Aug 15, 2014

See how to receive time_boot_ms and how to convert it to ros::time();

I don't do it. Easier use ros::Time::now().

@vooon
Copy link
Member

vooon commented Aug 15, 2014

I think i can merge it now and do corrections.

vooon added a commit that referenced this pull request Aug 15, 2014
@vooon vooon merged commit 3b05fed into mavlink:master Aug 15, 2014
@TSC21
Copy link
Member Author

TSC21 commented Aug 15, 2014

I don't do it. Easier use ros::Time::now().

Did you find out if PX4 can send GPS time?

@TSC21
Copy link
Member Author

TSC21 commented Aug 15, 2014

I'm going to do some corrections to complete what you merged so far already ;)

@TSC21
Copy link
Member Author

TSC21 commented Aug 15, 2014

Relative to the position_covariance_type: I think is going to depend if we send the covariance from the PX4 or not right? The covariance being used right now is just to fill the PoseWithCovarianceStamped message, but this covariance can be issued from the PX4 also.
So, for now, do you agree we set it as COVARIANCE_TYPE_UNKNOWN? This off course is to stay just 'till we have covariance published from PX4.

Can you add the Status part of the message please? I'm not really sure how to do it, even based on what you did in gps.cpp.

And that way we will have all fields of NavSatFix filled.

@vooon
Copy link
Member

vooon commented Aug 15, 2014

To calculate NavSat covariance i need EPH value, sended in GPS_RAW_INT.
I do it later, today repairing bixler (repair "duck face" after crash).

@TSC21
Copy link
Member Author

TSC21 commented Aug 15, 2014

OK. Good luck with the repairing then ;)
Can you please also add the NavSatStatus so to fill all the NavSatFix msg fields? Thanks!

vooon added a commit that referenced this pull request Aug 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

global_position.cpp plugin
2 participants