Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin API refactor #2 #241

Closed
3 tasks done
vooon opened this issue Mar 4, 2015 · 1 comment
Closed
3 tasks done

Plugin API refactor #2 #241

vooon opened this issue Mar 4, 2015 · 1 comment
Labels
API change plugin
Milestone
Version 0.11

Comments

@vooon
Copy link
Member

vooon commented Mar 4, 2015

I think that we may do some refactor for removing dead/unneeded code.

  1. Remove get_name() — because not needed, for documenting, blacklisting etc we used aliases.
  2. Move diagnostic updater to UAS (so we may add/remove diag tasks in connection slot)
  3. Move main node handle to UAS or remove it, because we may simply make new ros::NodeHandle("~/plugin")
    and previous NodeHandle("~") not needed.
@vooon vooon added this to the Version 0.11 milestone Mar 4, 2015
vooon added a commit that referenced this issue Mar 5, 2015
@vooon
plugin api #241: remove get_name()
d0208e4
vooon added a commit that referenced this issue Mar 5, 2015
@vooon
plugin api #241: remove global private node handle.
03da33a 
Now all plugins should define their local node handle (see dummy.cpp).
Also partially does #233 (unmerge setpoint topic namespace).
vooon added a commit that referenced this issue Mar 5, 2015
@vooon
plugin api #241: move diag updater to UAS.
ef44207
@vooon
Copy link
Member Author

vooon commented Mar 5, 2015

Done.

@vooon vooon closed this as completed Mar 5, 2015
@vooon vooon mentioned this issue Mar 9, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API change plugin
Projects
None yet
Milestone
Version 0.11
Development

No branches or pull requests
1 participant
@vooon