Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mavsys in .launch #293

Closed
tuloski opened this issue May 12, 2015 · 5 comments
Closed

mavsys in .launch #293

tuloski opened this issue May 12, 2015 · 5 comments
Labels
API change enhancement feature request
Milestone
Version 0.12

Comments

@tuloski
Copy link

tuloski commented May 12, 2015

Now it is not possible to put mavsys in the .launch file.
It'd be a nice feature to have.
@vooon
Copy link
Member

vooon commented May 12, 2015

Implementation steps:

  1. extend mavros/State: add connection status flag
  2. make ~/state latched type
  3. add flag (--wait) to mavsys that:
    a. waits rostopic creation
    b. waits until connection establish.

@vooon
Copy link
Member

vooon commented May 12, 2015

Also that flag may be very useful in some other tools.

  • mavcmd
  • mavsys

mavwp/mavparam not applicable because it must wait when plugin done pulls.

vooon added a commit that referenced this issue May 13, 2015
@vooon
sys_status #293: expose connection flag in mavros/State.
d234a48
vooon added a commit that referenced this issue May 13, 2015
@vooon
sys_status #293: initialize state topic
9c53abf
vooon added a commit that referenced this issue Jun 3, 2015
@vooon
mavcmd #293: Add --wait option.
7f3cb38 
New function: util.wait_fcu_connection(timeout=None) implement wait
option.
@vooon
Copy link
Member

vooon commented Jun 3, 2015

@tuloski Mavcmd wait implemented, need decide what tools also need it.

@vooon vooon added this to the Version 0.12 milestone Jun 4, 2015
vooon added a commit that referenced this issue Jun 5, 2015
@vooon
mavsys #293: add --wait option
b6927c3
@vooon
Copy link
Member

vooon commented Jun 5, 2015

Done.

@vooon vooon closed this as completed Jun 5, 2015
@tuloski
Copy link
Author

tuloski commented Jun 5, 2015

Thank you very much ;)

vooon added a commit that referenced this issue Jun 28, 2015
@vooon
Merge branch 'master' into coverity_scan
b6451c3 
* master: (24 commits)
  uncrustify: fix style on frame conversions
  uncrustify: includes
  plugin: sys_status #266: replace period with rate parameter
  plugin: sys_time #266: Replace period with rate parameters
  frame_conversion: last fix patch
  frame_conversions: use inline functions to identify direction of conversion
  changed frame conversion func name; add 3x3 cov matrix frame conversion; general doxygen comment cleanup
  frame_conversions: added covariance frame conversion for full pose 6x6 matrix
  frame_conversions: added frame_conversion specific lib file; applied correct frame conversion between ENU<->NED
  sys_status #300: PX4 place in [0] lest significant byte of git hash.
  sys_status fix #300: fix u8->hex func.
  plugin: waypoint: cosmetics.
  vibration_plugin: changed vibration to Vector3
  vibration_plugin: msg reformulation
  vibration_plugin: first commit
  Changes some frames from world to body conversion for NED to ENU.
  mavsys #293: add --wait option
  mavsys: Fix arguments help
  mavcmd #293: Add --wait option.
  libmavconn: UDP: Do not exit on Network unreachable error.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API change enhancement feature request
Projects
None yet
Milestone
Version 0.12
Development

No branches or pull requests
2 participants
@vooon @tuloski