Avoid duplicate specializations when using STI with an abstract base class #211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specialisation edge is added twice if an STI base class inherits from an abstract class. For example:
ApplicationRecord (abstract) -> Beverage (STI base) -> Beer -> (STI child)
causes theBeverage -> Beer
specialisation to occur twice. This causes Graphviz to fail in confusion with the message:This became a bigger issue with Rails 5, because the abstract base class
ApplicationRecord
is added by default.