Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bug when parameter to only option is a single model #300

Conversation

Kagemaru
Copy link
Contributor

The handling code expects the parameter to be an array and fails if it is a
symbol.

Please Note:

I was not able to get the test suite running. I get the same error as is currently on the Travis-CI.

Kagemaru and others added 3 commits June 28, 2018 13:13
The handling code expects the parameter to be an array and fails if it is a
symbol.
Repair square-brackets
@kerrizor
Copy link
Collaborator

Hi, and thanks for the PR! Apologies on not responding sooner; my workflow for being notified of new issues broke such that I received some notifications, but not all, and unfortunately yours was one I missed.

If you have the time, could you rebase and resubmit? I recently merged fixes for minitest that may help clear up your test failures.

@kerrizor
Copy link
Collaborator

Closing this in favor of #328 -- sorry @kronn that it dropped your contribution!

@kerrizor kerrizor closed this May 13, 2019
@Kagemaru Kagemaru deleted the feature/fixes_single_parameter_for_only_option branch January 16, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants