Pin minitest to 5.10.1 #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got back into the project this morning and noticed a TON of test failures in recent PRs. 5 min of research led me to these issues in recent versions of minitest and Rails. Since we use a variety of Rails versions, pinning the version minitest to one that works across legacy Rails versions is a solution for today, but we may have to take a look at a more sophisticated solution in the future. minitest/minitest#730 rails/rails#31624
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got back into the project this morning and noticed a TON of test
failures in recent PRs. 5 min of research led me to these issues in
recent versions of minitest and Rails. Since we use a variety of Rails
versions, pinning the version minitest to one that works across legacy
Rails versions is a solution for today, but we may have to take a look
at a more sophisticated solution in the future.
minitest/minitest#730
rails/rails#31624