Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis passes builds despite failing tests #56

Open
sindrehan opened this issue Feb 11, 2018 · 0 comments
Open

Travis passes builds despite failing tests #56

sindrehan opened this issue Feb 11, 2018 · 0 comments

Comments

@sindrehan
Copy link
Contributor

sindrehan commented Feb 11, 2018

Even though some/most of the tests are failing, Travis displays the build as passing.
I suspect that the reason for this is that the errors from rostest is not being passed out to the Docker-container and thus the build never fails.

Errors from roslint exit with a non-zero code, so the problem definetly lies with rostest.

Here is a log with failing tests, but a passing build.

@sindrehan sindrehan changed the title Travis does not fail despite failing tests Travis does passes builds despite failing tests Feb 11, 2018
@sindrehan sindrehan changed the title Travis does passes builds despite failing tests Travis passes builds despite failing tests Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant