This repository has been archived by the owner on Sep 27, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
Allow the pressure correction A to be adjustable #565
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@marvinbernhardt did you want to merge that into stable ( |
Codecov Report
@@ Coverage Diff @@
## master #565 +/- ##
========================================
- Coverage 60.4% 59.6% -0.8%
========================================
Files 124 124
Lines 7635 7722 +87
========================================
- Hits 4613 4610 -3
- Misses 3022 3112 +90
Continue to review full report at Codecov.
|
I think stable is better |
@votca-bot changelog: add max scaling parameter to pressure correction |
junghans
approved these changes
Jul 21, 2020
votca-bot
added a commit
to votca/votca
that referenced
this pull request
Jul 22, 2020
Thank you for adjustments and merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far there was a hard-coded value of 0.1 kBT. With this PR you can adjust it to max_A kBT. The default is still 0.1 kBT.