Skip to content
This repository has been archived by the owner on Sep 27, 2021. It is now read-only.

Allow the pressure correction A to be adjustable #565

Merged
merged 6 commits into from
Jul 22, 2020
Merged

Allow the pressure correction A to be adjustable #565

merged 6 commits into from
Jul 22, 2020

Conversation

marvinbernhardt
Copy link
Contributor

So far there was a hard-coded value of 0.1 kBT. With this PR you can adjust it to max_A kBT. The default is still 0.1 kBT.

@junghans
Copy link
Member

@marvinbernhardt did you want to merge that into stable (v1.6.2) or is master (v1.7) enough?

@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #565 into master will decrease coverage by 0.7%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #565     +/-   ##
========================================
- Coverage    60.4%   59.6%   -0.8%     
========================================
  Files         124     124             
  Lines        7635    7722     +87     
========================================
- Hits         4613    4610      -3     
- Misses       3022    3112     +90     
Impacted Files Coverage Δ
include/votca/csg/fileformatfactory.h 20.0% <0.0%> (-13.4%) ⬇️
src/libcsg/modules/io/h5mdtrajectoryreader.h 81.6% <0.0%> (-3.5%) ⬇️
include/votca/csg/cgengine.h 50.0% <0.0%> (-3.4%) ⬇️
src/tools/csg_resample.cc 70.5% <0.0%> (-3.1%) ⬇️
src/libcsg/cgmoleculedef.cc 69.5% <0.0%> (-2.1%) ⬇️
src/libcsg/modules/io/xmltopologyreader.cc 38.0% <0.0%> (-1.9%) ⬇️
src/libcsg/modules/io/groreader.cc 79.2% <0.0%> (-1.7%) ⬇️
src/tools/csg_stat_imc.cc 77.9% <0.0%> (-1.6%) ⬇️
src/libcsg/modules/io/pdbreader.cc 65.8% <0.0%> (-1.4%) ⬇️
src/libcsg/modules/io/lammpsdumpreader.cc 73.4% <0.0%> (-1.4%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 547a1d1...30d4639. Read the comment docs.

@junghans junghans changed the base branch from master to stable July 21, 2020 20:10
@junghans
Copy link
Member

I think stable is better

@junghans
Copy link
Member

@votca-bot changelog: add max scaling parameter to pressure correction

@junghans junghans merged commit 87271e7 into votca:stable Jul 22, 2020
votca-bot added a commit to votca/votca that referenced this pull request Jul 22, 2020
@marvinbernhardt
Copy link
Contributor Author

Thank you for adjustments and merge

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants