Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(ps): switch from CRA to vite #2018

Merged
merged 1 commit into from
Jun 24, 2022
Merged

build(ps): switch from CRA to vite #2018

merged 1 commit into from
Jun 24, 2022

Conversation

eventualbuddha
Copy link
Collaborator

Overview

Refs #1314

Demo Video or Screenshot

n/a

Testing Plan

Tested pnpm start in Chrome, pnpm build && make run in Chrome, pnpm test:watch and pnpm test:coverage.

Checklist

  • I have added logging where appropriate to any new user actions, system updates such as file reads or storage writes, or errors introduced.
  • I have added JSDoc comments to any newly introduced exports
  • I have added a screenshot and/or video to this PR to demo the change
  • I have added the "user_facing_change" label to this PR to automate an announcement in #machine-product-updates

@eventualbuddha eventualbuddha requested a review from a team as a code owner June 24, 2022 02:37
@eventualbuddha eventualbuddha requested review from carolinemodic and removed request for a team June 24, 2022 02:37
benadida
benadida approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@benadida benadida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a version downgrade for jest. If it's intentional, all good.

@eventualbuddha eventualbuddha merged commit 6f918f7 into main Jun 24, 2022
@eventualbuddha eventualbuddha deleted the build/ps/switch-to-vite branch June 24, 2022 12:12
@eventualbuddha
Copy link
Collaborator Author

I see a version downgrade for jest. If it's intentional, all good.

Yes, intentional for now.

@eventualbuddha eventualbuddha mentioned this pull request Feb 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benadida benadida benadida approved these changes

@jonahkagan jonahkagan Awaiting requested review from jonahkagan

@carolinemodic carolinemodic Awaiting requested review from carolinemodic carolinemodic was automatically assigned from votingworks/vxsuite-eng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eventualbuddha @benadida