Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

001 - Voucher Transactions + list validation rules assignments #240

Closed
wants to merge 47 commits into from

Conversation

weronika-kurczyna
Copy link
Contributor

@weronika-kurczyna weronika-kurczyna commented Sep 25, 2023


'@voucherify/sdk': minor

Added support for following endpoints:

  • GET /vouchers/{code}/transactions (client.vouchers.listTransactions(code, query))
  • POST /vouchers/{code}/transactions/export (client.vouchers.exportTransactions(code, body))
  • GET /validation-rules-assignments (client.client.validationRules.listRulesAssignments(validationRuleId))

New exported types/interfaces
Domain types:

  • GiftCardTransaction
  • GiftCardTransactionBase
    GiftCardTransactionDetails
  • GiftCardTransactionRedemptionDetails
  • GiftCardTransactionRefundDetails
  • GiftCardTransactionAdditionDetails
  • GiftCardTransactionRemovalDetails
  • VoucherTransaction
  • VoucherTransactionsExportFields
  • ValidationRulesAssignment

0-level types:

  • VouchersListTransactionsRequestQuery
  • VouchersListTransactionsResponseBody
  • VouchersExportTransactionsRequestBody
  • VouchersExportTransactionsResponseBody
  • ValidationRulesListRulesAssignmentsRequestQuery
  • ValidationRulesListRulesAssignmentsResponseBody

Other changes

  • Use VouchersExportTransactionsRequestBody as LoyaltiesExportCardTransactionsRequestBody (these types are identical, both related to the export of loyalty card transactions)
  • Use VouchersExportTransactionsResponseBody as LoyaltiesExportCardTransactionsResponseBody ((these types are identical, both related to the export of loyalty card transactions))

@weronika-kurczyna weronika-kurczyna changed the title Wk/types 001 - Add missing methods to Vouchers 001 - Voucher Transactions + list validation rules assignments Oct 19, 2023
@weronika-kurczyna weronika-kurczyna marked this pull request as ready for review October 19, 2023 15:16
@p-zielinski p-zielinski mentioned this pull request Oct 30, 2023
@marcin-slezak
Copy link
Contributor

released as a part of other RC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants