Fix widget work and changed to using bower-asset #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,21 +17,28 @@ class Asset extends AssetBundle | |||
| /** | |||
| * @inheritdoc | |||
| */ | |||
| public $sourcePath = '@vova07/select2/assets'; | |||
| public $sourcePath = '@vova07/select2/assets/select2-3.5.0'; | |||
There was a problem hiding this comment.
I'm not sure if this is right path. If we'll use bower-asset than it may be something like this: @bower/select2. Did you tested it?
|
Yes, sorry, wrong commits. Fixed path and tested now. Also, there is version 4 of Select2 is comming soom, where structure of the library have changed, I think, that it would be greate to migrate this widget to new version when it will be released |
vova07
added a commit
that referenced
this pull request
Jan 26, 2015
Fix widget work and changed to using bower-asset
|
Thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.