suite.js performs unsafe Object iterations without hasOwnProperty #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xternal Object prototype manipulations can't cause vows to break
|
I think your code still doesn't nail it 100%. if (Object.prototype.hasOwnProperty.call(options, k)) |
… it's been removed from the current object
|
fixed |
|
I went with 4347cdd, but thanks! |
|
@mmalecki that works too! Thanks for fixing this, I can now use the official vows module instead of my fork :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even in node.js, it's possible that the Object prototype can be modified with additional properties.
When this happens it is causing vows to fail because vows isn't checking hasOwnProperty() to ensure it's a real property.
This pull request adds the two checks needed in suite.js
I've run
npm testand tests pass.This pull request is ready to be merged.