Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tags to VideoEvents #545

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Adding tags to VideoEvents #545

merged 1 commit into from
Jan 21, 2022

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Jan 20, 2022

Better consistency with fiftyone.core.labels.TemporalDetection type.

@brimoor brimoor added the enhancement Code enhancement label Jan 20, 2022
@brimoor brimoor requested a review from a team January 20, 2022 22:21
@brimoor brimoor self-assigned this Jan 20, 2022
benjaminpkane
benjaminpkane approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brimoor brimoor mentioned this pull request Jan 21, 2022
Merged
@brimoor brimoor merged commit b5b6b15 into develop Jan 21, 2022
@brimoor brimoor deleted the labels branch January 21, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminpkane benjaminpkane benjaminpkane approved these changes

Assignees

@brimoor brimoor

Labels
enhancement Code enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brimoor @benjaminpkane