Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup tweaks #1258

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Setup tweaks #1258

merged 1 commit into from
Sep 9, 2021

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Sep 9, 2021

Small tweaks to align with teams.

@benjaminpkane is the fiftyone_desktop -> fiftyone-desktop change safe? I believe so since PyPI translates underscores to hyphens anyway, right?

@brimoor brimoor added the setup Package/system setup and configuration label Sep 9, 2021
@brimoor brimoor self-assigned this Sep 9, 2021
Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's safe. LGTM

@brimoor brimoor merged commit 9e492a2 into develop Sep 9, 2021
@brimoor brimoor deleted the tweaks branch September 9, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
setup Package/system setup and configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants