-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database name, admin, and type #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some useful utilities for configuring database access.
Database name
A new
database_name
config setting is added that allows for users to customize their MongoDB database name:export FIFTYONE_DATABASE_NAME=fiftytwo
unset FIFTYONE_DATABASE_NAME
Database/client types
Notions of database type and client type are added, and now database connections are refused if a Python client's type does not match the database's type.
The client type is hard-coded in
fiftyone.constants.CLIENT_TYPE
, and the database's type is stored in a newtype
field of theconfig
collection.This is an internal mechanism that exists to prevent OSS Python clients from connecting to non-OSS databases.
Database admin
A new
database_admin
config setting is added. This parameter defaults toTrue
, but clients can set it toFalse
, in which case database migrations are not allowed (other than lazily migrating a dataset to the current database version, which is normal usage):fiftyone migrate -v 0.15.0.1 export FIFTYONE_DATABASE_ADMIN=false
unset FIFTYONE_DATABASE_ADMIN
The documentation explains how this feature may be useful for OSS users leveraging
database_uri
to work on a shared database: