Apply extended stages before filters in extended view #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2710.
Applies extended stages (panel selections, similarity sorts) before sidebar filters when constructing the extended view.
In general, since view stages are applied serially in a pipeline, we may have to update the extended view logic to remember the order in which the user's operations were performed in order to produce exactly the view they are looking at.
HOWEVER, the only extended view stages that we currently use operate solely based on selecting sample/label IDs, so, for now, it's true that putting them first and then applying filters will always match what the user is looking at in the grid.