Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve static operator IO at execute time #4152

Merged
merged 1 commit into from Mar 16, 2024

Conversation

imanjra
Copy link
Contributor

@imanjra imanjra commented Mar 11, 2024

What changes are proposed in this pull request?

(Please fill in changes proposed in this fix)

How is this patch tested? If it is not, please explain why.

(Details)

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 48.71795% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 16.00%. Comparing base (b3cdf12) to head (4e28d33).
Report is 52 commits behind head on release/v0.23.7.

❗ Current head 4e28d33 differs from pull request most recent head 049c694. Consider uploading reports for the commit 049c694 to get more accurate results

Files Patch % Lines
app/packages/operators/src/operators.ts 0.00% 16 Missing ⚠️
app/packages/operators/src/state.ts 0.00% 14 Missing ⚠️
...pp/packages/looker/src/elements/common/controls.ts 50.00% 2 Missing ⚠️
app/packages/flashlight/src/constants.ts 0.00% 1 Missing ⚠️
app/packages/flashlight/src/index.ts 0.00% 1 Missing ⚠️
app/packages/flashlight/src/section.ts 0.00% 1 Missing ⚠️
app/packages/flashlight/src/state.ts 0.00% 1 Missing ⚠️
app/packages/flashlight/src/util.ts 0.00% 1 Missing ⚠️
app/packages/flashlight/src/zooming.ts 0.00% 1 Missing ⚠️
app/packages/looker/src/elements/common/options.ts 66.66% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@               Coverage Diff                @@
##           release/v0.23.7    #4152   +/-   ##
================================================
  Coverage            16.00%   16.00%           
================================================
  Files                  734      734           
  Lines                82229    82207   -22     
  Branches              1119     1119           
================================================
  Hits                 13159    13159           
+ Misses               69070    69048   -22     
Flag Coverage Δ
app 16.00% <48.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imanjra imanjra force-pushed the bugfix/static-operator-context branch from 1bc4c39 to 4e28d33 Compare March 12, 2024 16:35
@imanjra imanjra marked this pull request as ready for review March 12, 2024 16:35
@imanjra imanjra requested a review from a team March 13, 2024 12:35
@brimoor
Copy link
Contributor

brimoor commented Mar 15, 2024

@imanjra can you retarget this at release/v0.23.7 please?

@imanjra imanjra force-pushed the bugfix/static-operator-context branch from 4e28d33 to 049c694 Compare March 15, 2024 21:33
@imanjra imanjra changed the base branch from develop to release/v0.23.7 March 15, 2024 21:33
@brimoor brimoor merged commit 1f058b1 into release/v0.23.7 Mar 16, 2024
@brimoor brimoor deleted the bugfix/static-operator-context branch March 16, 2024 22:55
@imanjra imanjra mentioned this pull request Mar 26, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants